-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create annotated, signed tags #2
base: master
Are you sure you want to change the base?
Conversation
Nice. I was also thinking about some What's your opinion on using the flag |
If you use You could also provide the option to (GPG) sign the tags. |
Sorry, I meant naming the flag for bumpversion Sure, |
Another option, maybe achieving both with more configurability: What about keeping that generic (looking at about mercurial support, which I don't know that well) and providing a |
Agreed, sounds good. I'll update accordingly. |
Maybe check whether mercurial supports a similar workflow first. I'd like to keep general configuration generic and special configuration special. Sent from my pocket calculator Am 22.04.2013 um 12:50 schrieb Gert Van Gool [email protected]:
|
When creating annotated tags (by passing a message into them), you can use "git describe".
I'm not entirely happy at the moment with the escaping, but you can pass anything to the underlying command ( Maybe you have an idea what I need to change in the parser to fix this: ~/env/test/bin/bumpversion --tag-options '"-m \"bumpversion2 v{new_version}\""' I was hoping to get to
|
Any plans on completing this? |
@ekohl, you're right. this is a long-standing feature wish. I'm not using annotated tags myself, so getting this right involves a bit of research for me (how are people using annotated signed tags, how about a good default message, etc.). Patches including tests and documentation are always welcome though :) |
@gvangool are you going to finish this or do you mind if I take your code, rebase it and complete it? @peritus my use case is having a meaningful git describe and that uses annotated tags. This code looks like a good start, though I don't like exposing the raw options. I'm leaning toward simplicity and just expose a tag_message template similar to the commit message and tag_signed boolean flag. |
@ekohl no problem, go wild! I'm not using it at my current job. So haven't looked at it in while. |
Yes, I'm also not in favor of exposing raw options. Simplicity is king, but so is a universal, versatile, complete solution. @ekohl If you urgently need this, I'd be happy to collaborate with you on a patch to accelerate this. |
@peritus I wouldn't say urgently, but I would be interested. I will try to finish the rebase into a minimal working version and submit a new pull request. There we can discuss it further. |
Sounds great, looking forward to it! |
I opened #58 |
@peritus Just to note that annotated tags are an absolute showstopper for me, no point adopting bumpversion without this feature imho. I'm sure many others feel the same. Anything I can do to help get this in please shout! |
@peritus I'd like to bump this as well. We also prefer using signed release tags at my current job. |
When creating annotated tags (by passing a message into them), you can use
git describe
.For us, this is wanted behavior (anyone can see exactly what version they're using), but it's a matter of preference.